-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for update to particle-cli #175
Conversation
This stores a timestamp of the last update check and version (if newer) in the profile.json file. Fixes #138
@monkbroc thoughts? |
|
||
function check(next) { | ||
console.error('particle-cli v' + info.version); | ||
console.error(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't add this new output at the beginning of every CLI invocation. Is this only for debugging on this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be very helpful when helping troubleshoot to have the version number there. It removes a round trip of us asking for the version. I did have it go to stderr
instead so that if scripts were processing stdout
they would not be affected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By reducing the roundtrip you mean when talking on the forum or support tickets? Hopefully the number of people using old versions will go down with this feature!
I still think the version number will be additional noise for regular users. How about putting the current version in displayVersionBanner
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough. What I really want is a log file when errors happen, which could contain the version number. This was just a stopgap until that happens.
Check for update to particle-cli
This stores a timestamp of the last update check and version (if newer)
in the profile.json file.
Fixes #138