Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for update to particle-cli #175

Merged
merged 4 commits into from
Jan 13, 2016
Merged

Check for update to particle-cli #175

merged 4 commits into from
Jan 13, 2016

Conversation

brycekahle
Copy link
Contributor

This stores a timestamp of the last update check and version (if newer)
in the profile.json file.

Fixes #138

screen shot 2015-12-01 at 7 17 23 pm

This stores a timestamp of the last update check and version (if newer)
in the profile.json file.

Fixes #138
@brycekahle
Copy link
Contributor Author

@monkbroc thoughts?

@brycekahle brycekahle changed the title Check for updates at most once an hour Check for update to particle-cli Dec 2, 2015

function check(next) {
console.error('particle-cli v' + info.version);
console.error();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't add this new output at the beginning of every CLI invocation. Is this only for debugging on this branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be very helpful when helping troubleshoot to have the version number there. It removes a round trip of us asking for the version. I did have it go to stderr instead so that if scripts were processing stdout they would not be affected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By reducing the roundtrip you mean when talking on the forum or support tickets? Hopefully the number of people using old versions will go down with this feature!

I still think the version number will be additional noise for regular users. How about putting the current version in displayVersionBanner instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. What I really want is a log file when errors happen, which could contain the version number. This was just a stopgap until that happens.

brycekahle added a commit that referenced this pull request Jan 13, 2016
@brycekahle brycekahle merged commit c6d533a into master Jan 13, 2016
@brycekahle brycekahle deleted the feature/version-check branch January 13, 2016 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants