Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also include .hpp, .hxx and .hh #511

Merged
merged 3 commits into from Aug 14, 2019

Conversation

@nikeee
Copy link
Contributor

commented Aug 12, 2019

Currently, particle-cli only supports .h files. For C++, there is a common convention that .hpp, .hxx or .hh can also be used for header files.

This PR allows .hpp, .hxx and .hh as header file extensions.

@ScruffR

This comment has been minimized.

Copy link

commented Aug 13, 2019

Would be good if we also got some means to also allow "arbitrary" files/extensions - e.g. via a particle.include file (much like the previously accepted spark.ignore file in pre libraries 2.0 versions of CLI)

@busticated

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

thanks @nikeee 👍

it'd be nice to have companion tests to verify the expected behavior. perhaps something can be easily added here or as an end-to-end test over here. end-to-end test docs are over here

@busticated

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

@nikeee not sure what's up w/ CI - i tried re-running without any luck then i pulled down your branch and tests pass locally 🤔😑

nikeee added some commits Aug 14, 2019

@nikeee

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

I added an E2E test in 197f83c. However, I could not verify that it actually passes. Also, CI apperantly does not seem run the E2E tests...?

@busticated

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@nikeee

I added an E2E test in 197f83c.

🎉 awesome - very much appreciated 🙏

However, I could not verify that it actually passes

are you not able to run them locally? if so, i'd be interested in learning where things went wrong so future contributors will have an easier time.

Also, CI apperantly does not seem run the E2E tests...?

they run after the unit + integration tests so if you have a failure there (which you do - for some as yet unknown reason) then the e2e tests will never run.

i would say don't worry about wrestling with it for now - what you've provided is super-helpful. i'll get it merged ASAP 👍

@busticated busticated merged commit 197f83c into particle-iot:master Aug 14, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

busticated added a commit that referenced this pull request Aug 14, 2019

@busticated

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

@nikeee do you mind signing our Contributor License Agreement? for some reason i thought you had already done that 😊

@nikeee

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Done.

@nikeee nikeee deleted the nikeee:support-hpp branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.