Device ownership transfer is broken #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busticated
reviewed
Feb 7, 2020
| @@ -54,7 +54,7 @@ class CloudCommand { | |||
| return api.claimDevice(deviceId).then(() => { | |||
| console.log('Successfully claimed device ' + deviceId); | |||
| }, (err) => { | |||
| if (err && typeof err === 'string' && err.indexOf('That belongs to someone else.') >= 0) { | |||
| if (err && typeof err[0] === 'string' && err[0].indexOf('That belongs to someone else.') >= 0) { | |||
There was a problem hiding this comment.
how about adding a test so we don't hit the same issue down the road?
https://github.com/particle-iot/particle-cli/blob/master/test/e2e/cloud.e2e.js#L174-L185
There was a problem hiding this comment.
Could you help me with that since the test needs to answer a prompt? It's not just checking stdout. It will also need a new environment variable for a device that is claimed to another account.
|
Thanks for the example. I'll remember that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.clubhouse.io/particle/story/46854
Steps to reproduce:
particle device add <deviceId>for a device that is already claimed to another account