New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 121837/support local flash without internet access #678
Merged
hugomontero
merged 15 commits into
master
from
feature/sc-121837/support-local-flash-without-internet-access
Oct 12, 2023
Merged
Feature/sc 121837/support local flash without internet access #678
hugomontero
merged 15 commits into
master
from
feature/sc-121837/support-local-flash-without-internet-access
Oct 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
force-pushed
the
feature/sc-121837/support-local-flash-without-internet-access
branch
from
October 3, 2023 15:54
846d6b3
to
ebb7ad3
Compare
monkbroc
reviewed
Oct 5, 2023
hugomontero
force-pushed
the
feature/sc-121837/support-local-flash-without-internet-access
branch
from
October 11, 2023 21:21
851b69b
to
a0f63fd
Compare
hugomontero
force-pushed
the
feature/sc-121837/support-local-flash-without-internet-access
branch
from
October 11, 2023 21:39
a0f63fd
to
3318a92
Compare
monkbroc
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it. It works great now and we have a repeatable pattern for offline usage of the API!
…ed in other layer
… the selected one
hugomontero
force-pushed
the
feature/sc-121837/support-local-flash-without-internet-access
branch
from
October 12, 2023 16:43
30ad319
to
99f43e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow the use of flashing device os offline.
When the user downloads an specific device os version it will be cached in a file, then if the user tries to download it again without internet access, then the
cli
will looks into the cached file to try to flash the device.How to Test
git pull && git checkout feature/sc-121837/support-local-flash-without-internet-access
npm i
npm test
steps with internet access
steps without internet access
device-os-version-cached.json
from~/.particle/device-os-flash/binaries
steps without internet access
~/.particle/device-os-flash/binaries/${version}/${platform}
steps without internet access
Steps with internet access:
npm start -- update
npm start -- update --target 5.0.0
Steps Without internet access
npm start -- update
npm start -- update --target 5.0.0
outcome
~/.particle/device-os-flash/binaries
nameddevice-os-version-cached.json
Device OS version not found in cache for platform: ${platformId} version: ${version} and there was an internet connection error
Related Issues / Discussions
Story details 👉 https://app.shortcut.com/particle/story/121837/support-local-flash-without-internet-access
Completeness