New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 122867/make particle usb flash be aware of device #681
Feature/sc 122867/make particle usb flash be aware of device #681
Conversation
b4fc847
to
2c7a99d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't ready to merge. It broke the auto DFU switch in particle flash --local
$ particle flash --local
? Which device would you like to select?
extra_p2 [0a10aced202194944a02c5f4] (Photon 2 / P2)
❯ <unknown> [18002b000247353138383138] (Photon, LISTENING)
Flashing photon 18002b000247353138383138
!!! The device needs to be in DFU mode for this command.
> To put your device in DFU manually, please:
1) Press and hold both the RESET and MODE/SETUP buttons simultaneously.
2) Release only the RESET button while continuing to hold the MODE/SETUP button.
3) Release the MODE/SETUP button once the device begins to blink yellow.
Put the device in DFU mode and try again
I think this message is regarding the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good with the last fix
e8a2a3b
to
6dc10f8
Compare
…d for an specific binary
510e162
to
54faf90
Compare
54faf90
to
74b1a01
Compare
Description
This PR will make
flash --usb
be aware of the device mode and the platform depending on thebinary
to be flashed.How to Test
DFU
user-part
application and platformoutcome
Tinker
flash --usb tinker
outcome
Explanation:
Tinker word doesn't have anything that we could guess the platform the user wants to flash. That's the reason we show all connected devices with DFU mode actived.
Normal mode / listening
outcome
Regression testing
npm start -- update
npm start -- flash --local ...
Related Issues / Discussions
Story details: https://app.shortcut.com/particle/story/122867
Completeness