Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/project e2e tests #683

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Fix/project e2e tests #683

merged 4 commits into from
Oct 17, 2023

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented Oct 17, 2023

Fix e2e tests per the new project template

How to Test

Checkout this branch locally and run npm rum test:e2e

Related Issues / Discussions

https://app.circleci.com/pipelines/github/particle-iot/particle-cli/576/workflows/5eb5695f-d951-4737-a4df-f05d434796ac/jobs/4799

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@keeramis
Copy link
Contributor Author

One note that in one of the runs, I ran into the following. Rerunning helped.

1) Library Commands
       Library Create Subcommand
         Creates a library:

      AssertionError: expected [ Array(30) ] to be a superset of [ Array(6) ]
      + expected - actual

       [
      -  "(node:10928) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency"
      -  "(Use `node --trace-warnings ...` to show where the warning was created)"
      -  "(node:10928) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'chmod' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'cp' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'dirs' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'pushd' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'popd' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'echo' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'tempdir' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'pwd' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'exec' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'ls' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'find' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'grep' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'head' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'ln' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'mkdir' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'rm' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'mv' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'sed' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'set' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'sort' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'tail' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'test' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'to' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'toEnd' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'touch' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'uniq' of module exports inside circular dependency"
      -  "(node:10928) Warning: Accessing non-existent property 'which' of module exports inside circular dependency"
      +  "   create library.properties"
      +  "   create README.md"
      +  "   create LICENSE"
      +  "   create src/testlib.cpp"
      +  "   create src/testlib.h"
      +  "   create examples/usage/usage.ino"
       ]
      
      at Context.<anonymous> (test/e2e/library.e2e.js:826:42)
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:95:5)

@@ -55,12 +55,12 @@ describe('Library Commands', () => {

afterEach(async () => {
await fs.emptyDir(PATH_PARTICLE_LIBRARIES_DIR);
await fs.emptyDir(PATH_TMP_DIR);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to cleaning after each test

@keeramis keeramis merged commit 2f457df into master Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants