Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/sc-122892/wrong-message-when-attempt-to-use-particle #684

Merged

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Oct 17, 2023

Description

This PR will fix the message when we attempt to run a command with no devices connected in the context of: particle update particle flash -- local particle flash --usb

How to Test

  • Disconnect all devices from your computer
  • Do a particle update | particle flash --local ... | particle flash --usb ...

Current behavior
It will appears the follow message:

!!! The device needs to be in Normal mode for this command.

> To put your device in Normal mode manually, please:

Press the RESET button and Release it
No devices found

New Behavior
It will appears the follow message:
No devices found

Related Issues / Discussions

Story details: https://app.shortcut.com/particle/story/122892

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

Copy link
Contributor

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

particle-cli (bug/sc-122892/wrong-message-when-attempt-to-use-particle) $ particle update
No device found
------------------------------------------------------------

 particle-cli (bug/sc-122892/wrong-message-when-attempt-to-use-particle) $ particle flash --usb
Send firmware to your device
.
.
You must specify a device or a file
------------------------------------------------------------------

 particle-cli (bug/sc-122892/wrong-message-when-attempt-to-use-particle) $ particle flash --local
No device found

@hugomontero hugomontero force-pushed the bug/sc-122892/wrong-message-when-attempt-to-use-particle branch from 8d419d0 to bc5f983 Compare October 17, 2023 15:51
@hugomontero hugomontero merged commit d2ad5dc into master Oct 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants