Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/sc-123488/setup-e2e-tests-for-particle-cli-in-local #689

Merged

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Nov 16, 2023

Description

This PR will improve some e2e that are currently failing, and also improve the test README to be more clear regarding how to configure the devices required for testing.

How to Test

  1. Pull down the branch: git pull && git checkout chore/sc-123488/setup-e2e-tests-for-particle-cli-in-local
  2. Attempt to configure your test environment by following test/README.md
  3. Run e2e tests: npm run test:e2e

Observations:

  • MACOS environments might fail on
 Library Create Subcommand
      3) Creates a library

(This is related with shelljs issue after updating to node16)

  • Trying to use electron sometimes failed in:
Variable Commands [@device]
       Variable Get Subcommand
         Gets a variable by name

Even though having the right application.
You'll see that your variable version is '*' and is expecting '42'. ( ignore this failure since that's the result we are receiving from cloud also)
image

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero force-pushed the chore/sc-123488/setup-e2e-tests-for-particle-cli-in-local branch from de9e30b to 9d05e91 Compare November 17, 2023 23:21
@hugomontero hugomontero marked this pull request as ready for review November 17, 2023 23:32
@hugomontero hugomontero force-pushed the chore/sc-123488/setup-e2e-tests-for-particle-cli-in-local branch from 1056f33 to 1ac9e0d Compare November 21, 2023 13:57
@hugomontero hugomontero changed the title Chore/sc 123488/setup e2e tests for particle cli in local chore/sc-123488/setup-e2e-tests-for-particle-cli-in-local Nov 21, 2023
@hugomontero hugomontero merged commit 2c72f4a into master Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants