CLI Logic Functions - Deploy #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeramis
requested review from
hugomontero and
monkbroc
and removed request for
monkbroc and
hugomontero
hugomontero
reviewed
Dec 13, 2023
src/cmd/logic-function.test.js
Outdated
| @@ -340,7 +338,7 @@ describe('LogicFunctionCommands', () => { | |||
|
|
|||
| const paths = ['dir/', 'dir/path/to/file']; | |||
There was a problem hiding this comment.
Might be good to change this since paths[0] is not being used anymore, maybe you just need to define a jsonPath field and pass it to your function (will be more clean and clear)
monkbroc
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
deployfunctionality.Removes saving the Logic Function to a logic-function-directory and saves them directly in the CWD.
- Does NOT do
current-working-directory/LF/LF.json- Does
current-working-directory/LF.jsonHow to Test
particle lf createparticle lf deployRelated Issues / Discussions
https://app.shortcut.com/particle/story/123398/implement-deploy-command
Completeness