CLI Logic Function - Enable #700
Conversation
src/cmd/logic-function.js
Outdated
| @@ -334,19 +334,23 @@ module.exports = class LogicFunctionsCommand extends CLICommandBase { | |||
| console.log(org, filepath); | |||
| } | |||
|
|
|||
| async disable({ org, name, id }) { | |||
| async disable({ org, name, id }, status) { | |||
There was a problem hiding this comment.
I'd rather to extract the inner functions that disable / enable the logicFunction instead of giving a new responsibility to disable function.
There was a problem hiding this comment.
What I mean with that is to create a new function enable and extract the logic to change the status.
Something important if the user execute twice the enable command the logic-function should remains enable. Same thing with disable command
There was a problem hiding this comment.
Something important if the user execute twice the enable command the logic-function should remains enable.
It will still remain to be enabled. It's the same functionality other than the bit flip so I think we can keep it under the same function? The only other difference is the output logs which is different for enable and disable. The important point is that the functionality is the same with different bits for false/true for the logic_function.enabled so I would like to keep it under the same function unless I am missing something here?.
There was a problem hiding this comment.
I have also tested enabling in the console, disabling in the CLI and vice verse.
And enabling and disabling multiple times work as expected
There was a problem hiding this comment.
Here the thing is the function name is disable and do something else than disable a logicFunction. That's the main reason.
There was a problem hiding this comment.
if you want to keep the same functionality then change the function name to updateStatus or something that specifies the actual thing the function is doing.
keeramis
force-pushed
the
feature/sc-123399/enable
branch
from
2e3479d
to
8e93dba
Compare
Description
Implements
enablecommand to enable a Logic FunctionHow to Test
particle lf enable --name myLFRelated Issues / Discussions
https://app.shortcut.com/particle/story/124133/implement-enable-command
Completeness