Feature/sc 124023/get refactor #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
changed the base branch from
feature/logic-function
to
feature/sc-124023/create-logic-function-helper-to-put-file
hugomontero
commented
Dec 18, 2023
| // TODO - implement | ||
| throw new Error(`Not implemented yet for ${id} or ${name} or ${list}`); | ||
| // throw new Error(`Not implemented yet for ${id} or ${name}`); | ||
| const logicFunctionData = list.find(lf => lf.id === id || lf.name === name); |
There was a problem hiding this comment.
Even thought this one just filter the list (can be handled directly from cmd) I decided keep it in case in the future we want to get this directly from the cloud instead of listing all logic functions
hugomontero
commented
Dec 18, 2023
Comment on lines
+116
to
+140
| function createAPIErrorResult({ error: e, message, json }){ | ||
| const error = new VError(formatAPIErrorMessage(e), message); | ||
| error.asJSON = json; | ||
| return error; | ||
| } | ||
|
|
||
| function formatAPIErrorMessage(error){ | ||
| error = normalizedApiError(error); | ||
|
|
||
| if (error.body){ | ||
| if (typeof error.body.error === 'string'){ | ||
| error.message = error.body.error; | ||
| } else if (Array.isArray(error.body.errors)){ | ||
| if (error.body.errors.length === 1){ | ||
| error.message = error.body.errors[0]; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (error.message.includes('That belongs to someone else.')){ | ||
| error.canRequestTransfer = true; | ||
| } | ||
|
|
||
| return error; | ||
| } |
There was a problem hiding this comment.
This should be in api.js file maybe? I saw this repetitive code in every cmd file but it's more related with how we treat api errors.
hugomontero
changed the base branch from
feature/sc-124023/create-logic-function-helper-to-put-file
to
feature/logic-function
monkbroc
force-pushed
the
feature/sc-124023/get-refactor
branch
from
ab88b25
to
4c248ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all changes related with
logic-functionrefactor for thegetcommand.Important!
Currently the
logic.jsoncreation doesn't have the right structure. That error were fixed in this PR #705How to Test
git pull && git checkout feature/sc-124023/get-refactornpm inpm run test:cinpm start -- lf list --org ${my_org}||npm start -- lf listlfeither for sandbox or org:npm start -- lf get --name "my logic function" --org ${my_org} /my/path/lfwithout params:npm start -- lf getoutcome
lflfit will create two files in the path you picklfRelated Issues / Discussions
Story details: https://app.shortcut.com/particle/story/124023
Completeness