-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 124023/execute refactor #707
Merged
hugomontero
merged 14 commits into
feature/logic-function
from
feature/sc-124023/execute-refactor
Jan 4, 2024
Merged
Feature/sc 124023/execute refactor #707
hugomontero
merged 14 commits into
feature/logic-function
from
feature/sc-124023/execute-refactor
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f8c87a
to
bfda1bb
Compare
keeramis
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will re-define the accepted params for
execute
anddeploy
and also useclass
pattern for logic functiondeploy
andexecute
commandsHow to Test
git pull && git checkout feature/sc-124023/execute-refactor
npm i
npm run test:ci
&npm run test:e2e -- --grep "Logic Function Commands"
Suggested tests:
Execute LF without params:
Having a current Logic function (you can use
npm start -- lf create
to create a fresh one) run:npm start -- lf execute /my/logic/function/path
npm start -- lf execute /my/logic/function/path/file.js
npm start -- lf execute /my/logic/function/path/file.logic.js
outcome
Execute LF using
--name
--id
Having a current Logic function (you can use
npm start -- lf create
to create a fresh one) run:In case of the
--id
use the commandnpm start -- lf get --name <logic-function-name>
in order to download an existent LFnpm start -- lf execute /my/logic/function/path --name <logic-function-name>
npm start -- lf execute /my/logic/function/path --name "wrong name"
npm start -- lf execute /my/logic/function/path --id <logic-function-id>
outcome
logic.json
file containsid
then it will be executed successfullyExecute LF using a path with several LF inside
Having a several Logic functions (you can use
npm start -- lf create
to create fresh ones) run:npm start -- lf execute /my/logic/function/path
outcome
Execute LF using a path with several LF inside with malformed ones
Having a several Logic functions (you can use
npm start -- lf create
to create fresh ones) run:.js
npm start -- lf execute /my/logic/function/path
outcome
You will see a message indicating that there is a malformed logic function and the related error (in this case:
.js
doesn't exist)Common cases
device_id
product_id
data
payload
Deploy logic functions
Suggest to use the same tests than before just with
deploy
command insteadRelated Issues / Discussions
Story details: https://app.shortcut.com/particle/story/124023
Completeness