New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 124023/disable enable refactor #708
Feature/sc 124023/disable enable refactor #708
Conversation
20b4e26
to
dd370a7
Compare
dd370a7
to
88a6b4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this.files.sourceCode.content = logicFunction.files.sourceCode.content; | ||
this.files.configuration.content = logicFunction.files.configuration.content; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the copyFromOtherLogicFunction
for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is used to "sync" a logicFunction from another one. Specifically is used to copy values from "cloud" to "local" but is more generic than that.
Description
This PR will change updateStatus command in order to use LogicFunction Class
How to Test
git pull && git checkout feature/sc-124023/disable-enable-refactor
npm i
npm run test:ci
&&npm run test:e2e -- --grep "Logic Function Commands"
Outcome
Related Issues / Discussions
Story details: https://app.shortcut.com/particle/story/124023
Completeness