Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/sc 125552/remove yeoman generator from particle library #718

Merged

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Mar 5, 2024

Description

This PR will remove Yeoman dependency and update the way we init new libraries.

How to Test

  1. Pull down the branch git pull && git checkout chore/sc-125552/remove-yeoman-generator-from-particle-library
  2. Install dependencies: npm install 👉 Required since we removed dependencies
  3. Run tests
  4. Attempt to create a new library: npm start -- library create --dir /my/path/dir
    • Use the different options from the command

outcome

  • Tests should pass
  • When creating a library you should be prompted for details like library name, version, etc.
  • Your library will be created in the dir you targeted.

Related Issues / Discussions

Story details:

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero force-pushed the chore/sc-125552/remove-yeoman-generator-from-particle-library branch from 3c0572f to c049df5 Compare March 13, 2024 15:07
@hugomontero hugomontero marked this pull request as ready for review March 13, 2024 15:07
@hugomontero
Copy link
Contributor Author

:shipit:

@hugomontero hugomontero merged commit cec0060 into master Mar 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants