Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade serialport to v12 #723

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Upgrade serialport to v12 #723

merged 3 commits into from
Apr 1, 2024

Conversation

monkbroc
Copy link
Member

@monkbroc monkbroc commented Mar 28, 2024 •
edited
Loading

Serialport v12 includes packages for Apple x64+arm64 so it should unblock the installer for Mac.

node_modules/@serialport/bindings-cpp/prebuilds/android-arm64/node.napi.armv8.node
node_modules/@serialport/bindings-cpp/prebuilds/android-arm/node.napi.armv7.node
node_modules/@serialport/bindings-cpp/prebuilds/darwin-x64+arm64/node.napi.node
node_modules/@serialport/bindings-cpp/prebuilds/linux-arm64/node.napi.armv8.node
node_modules/@serialport/bindings-cpp/prebuilds/linux-arm/node.napi.armv6.node
node_modules/@serialport/bindings-cpp/prebuilds/linux-arm/node.napi.armv7.node
node_modules/@serialport/bindings-cpp/prebuilds/linux-x64/node.napi.glibc.node
node_modules/@serialport/bindings-cpp/prebuilds/linux-x64/node.napi.musl.node
node_modules/@serialport/bindings-cpp/prebuilds/win32-ia32/node.napi.node
node_modules/@serialport/bindings-cpp/prebuilds/win32-x64/node.napi.node

Ensure these commands run

  • particle serial list
  • particle serial monitor
  • particle serial wifi

hugomontero
hugomontero approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@hugomontero hugomontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested in arm64 / x64 macos and worked great!

@monkbroc monkbroc merged commit cf69d8f into feature/cli-installer-v2 Apr 1, 2024
7 checks passed
@monkbroc monkbroc deleted the feature/sc-126683/upgrade-serialport-to-v12 branch April 1, 2024 13:41
@hugomontero hugomontero mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomontero hugomontero hugomontero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@monkbroc @hugomontero