Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sign script for win #724

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Apr 1, 2024

Description

This PR will sign windows .exe output from particle-cli.

How to Test

  • Wait for circleci
  • Download build/particle-cli-win-x64.exe
  • Check if the signature is valid running: Get-AuthenticodeSignature -FilePath .\Mypath\particle-cli-win-x64.exe
    image

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero marked this pull request as ready for review April 2, 2024 14:53
@hugomontero hugomontero merged commit 5ae0108 into feature/cli-installer-v2 Apr 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants