-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sc 126216/update linux mac cli installer to use new #727
Feature/sc 126216/update linux mac cli installer to use new #727
Conversation
2694b20
to
4f8dfbd
Compare
|
||
VERSION=${VERSION} | ||
BINARY="particle" | ||
DEST_PATH="$HOME/bin" | ||
DEST="$DEST_PATH/$BINARY" | ||
MANIFEST_URL="https://binaries.particle.io/particle-cli/manifest.json" | ||
MANIFEST_HOST=${MANIFEST_HOST:-binaries.particle.io} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use MANIFEST_HOST=binaries.staging.particle.io VERSION=3.23.0 ./install-cli
for testing
BINARY_URL=$(curl -s $MANIFEST_URL | $PYTHON -c "import sys, json; print(json.load(sys.stdin)['builds']['$OS']['$ARCH']['url'])") | ||
BINARY_SHA256=$(curl -s $MANIFEST_URL | $PYTHON -c "import sys, json; print(json.load(sys.stdin)['builds']['$OS']['$ARCH']['sha256'])") | ||
echo ":::: Installing the Particle CLI for $OS $ARCH" | ||
MANIFEST=$(curl -s --fail $MANIFEST_URL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--fail
causes curl to exit with error code 22 if the file can't be downloaded (HTTP 400 or above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I made a few tweak
Description
This PR will add cli-installer for unix systems (macos, linux)
How to Test
https://binaries.staging.particle.io/particle-cli/installer/install-cli
VERSION=3.23.0 ./{path}/install-cli
particle
command in a new terminal:particle update-cli --help
outcome
Once installed you will be able to see the new options for
update-cli
command:Related Issues / Discussions
Story details: https://app.shortcut.com/particle/story/126216
Completeness