Fix the asset check code #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monkbroc
force-pushed
the
bug/sc-127227/support-renamed-assets
branch
from
70babcd
to
d88bb6a
Compare
hugomontero
reviewed
Apr 15, 2024
| @@ -66,6 +66,12 @@ async function _flashDeviceInNormalMode(device, data, { name, progress, checkSki | |||
| } | |||
| return device; | |||
| } | |||
| try { | |||
There was a problem hiding this comment.
Makes more sense this approach since prepareToFlash always puts the device in listening for nonDFU modes.
I was thinking about a final reset after the whole process could be also a good way to have the device back to normal but would be too much since in all the times the device is being resetting when it flashes something hehe.
There was a problem hiding this comment.
Flashing with control requests resets by itself so it should be in a good state without an extra reset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fixes on top of #726