Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/sc-126222/update-the-particle-cli-executable-in-workbench #730

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented Apr 23, 2024

Description

This PR will:

  • Use Github Actions for ci/cd and remove circleci configuration
  • Fix issues with SSO login on linux systems without a display (i.e., servers)
  • Fix update-cli issues that prevent to be called in background
  • Remove arch and platform mappings by using the default os.platform and os.arch from nodejs
  • Use pkg.version to set the manifest version instead of the tag

How to Test

To check Github Actions:

  • Check the generated pipelines from staging and also pipelines from every commit.

To test cli improvements:

  • Download the generated build and use it (run the follow commands):
    • particle version
    • particle update-cli
    • particle flash --local tinker
    • particle serial monitor
    • particle usb list
    • particle list

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero changed the base branch from master to feature/cli-installer-v2 April 23, 2024 14:40
@hugomontero hugomontero force-pushed the feature/sc-126222/update-the-particle-cli-executable-in-workbench branch from ee41da0 to 45a0728 Compare April 25, 2024 21:05
@hugomontero hugomontero changed the title Feature/sc 126222/update the particle cli executable in workbench feature/sc-126222/update-the-particle-cli-executable-in-workbench Apr 26, 2024
@hugomontero hugomontero force-pushed the feature/sc-126222/update-the-particle-cli-executable-in-workbench branch 2 times, most recently from 6cf3273 to 03f7a33 Compare May 2, 2024 14:04
@monkbroc monkbroc force-pushed the feature/sc-126222/update-the-particle-cli-executable-in-workbench branch 15 times, most recently from 85b4caf to 8f2e4be Compare May 2, 2024 18:14
@hugomontero hugomontero force-pushed the feature/sc-126222/update-the-particle-cli-executable-in-workbench branch 10 times, most recently from 18a06a1 to 50eec7d Compare May 6, 2024 13:19
@hugomontero hugomontero force-pushed the feature/sc-126222/update-the-particle-cli-executable-in-workbench branch from b7bd5c1 to 18a3ba1 Compare May 8, 2024 16:44
@hugomontero hugomontero marked this pull request as ready for review May 8, 2024 21:40
@hugomontero hugomontero requested a review from monkbroc May 8, 2024 21:40
@hugomontero hugomontero merged commit 83bb991 into feature/cli-installer-v2 May 8, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants