Validating array indexes #116
Conversation
…the each command.
| @@ -57,6 +57,7 @@ public function validate($value) | |||
|
|
|||
| $result = true; | |||
| foreach ($value as $index => $innerValue) { | |||
| $innerValue['array_index'] = $index; | |||
There was a problem hiding this comment.
Nice hack to be able to validate the array keys, I like it! The only thing that I'm thinking about is the key name. Do we want to go with an underscore here, or do we want to go with camelCase, like php variables should be?
There was a problem hiding this comment.
That was one of my doubts as well. I only added the underscore because the output reads better when you do it, but it could be anything.
|
Thank you @camcima, I'm in favor of adding this. @berry-langerak what do you think? |
|
I'm not in favour just yet. Having one API to mix name of fields and a "magically" appearing name seems a little off to me. Let me consider an alternative, if you will, because I do think the functionality is very interesting. |
|
I'm going to close this PR, and convert this into a feature (#143). We still could consider to go with this PR, but we need to give it more thought. |
Added the functionality to validate the indexes of the arrays within the each command.