chore: remove a double quote from asset names #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzuki-shunsuke
temporarily deployed
to
external
GitHub Actions
Inactive
TestBefore$ goreleaser release --snapshot --clean
• starting release...
• loading path=.goreleaser.yml
• skipping announce, publish and validate...
• loading environment variables
• getting and validating git state
• git state commit=b1261a8544ac8e1b806de9dae11dd6b078308ada branch=main current_tag=v2.0.0 previous_tag=v1.12.0 dirty=false
• pipe skipped reason=disabled during snapshot mode
• parsing tag
• setting defaults
• snapshotting
• building snapshot... version=v2.0.0-next
• running before hooks
• running hook=go mod download
• took: 1s
• checking distribution directory
• cleaning dist
• loading go mod information
• took: 1s
• build prerequisites
• writing effective config file
• writing config=dist/config.yaml
• building binaries
• building binary=dist/kconf_windows_386/kconf.exe
• building binary=dist/kconf_linux_amd64_v1/kconf
• building binary=dist/kconf_linux_386/kconf
• building binary=dist/kconf_darwin_arm64/kconf
• building binary=dist/kconf_windows_amd64_v1/kconf.exe
• building binary=dist/kconf_linux_arm64/kconf
• building binary=dist/kconf_windows_arm64/kconf.exe
• building binary=dist/kconf_darwin_amd64_v1/kconf
• took: 1m4s
• archives
• creating archive=dist/kconf-linux-arm64-v2.0.0-next".tar.gz
• creating archive=dist/kconf-linux-386-v2.0.0-next".tar.gz
• creating archive=dist/kconf-windows-arm64-v2.0.0-next".tar.gz
• creating archive=dist/kconf-windows-x86_64-v2.0.0-next".tar.gz
• creating archive=dist/kconf-darwin-arm64-v2.0.0-next".tar.gz
• creating archive=dist/kconf-windows-386-v2.0.0-next".tar.gz
• creating archive=dist/kconf-linux-x86_64-v2.0.0-next".tar.gz
• creating archive=dist/kconf-darwin-x86_64-v2.0.0-next".tar.gz
• took: 3s
• calculating checksums
• storing release metadata
• writing file=dist/artifacts.json
• writing file=dist/metadata.json
• release succeeded after 1m9s
• thanks for using goreleaser!$ ls -1 dist
artifacts.json
checksums.txt
config.yaml
'kconf-darwin-arm64-v2.0.0-next".tar.gz'
'kconf-darwin-x86_64-v2.0.0-next".tar.gz'
'kconf-linux-386-v2.0.0-next".tar.gz'
'kconf-linux-arm64-v2.0.0-next".tar.gz'
'kconf-linux-x86_64-v2.0.0-next".tar.gz'
'kconf-windows-386-v2.0.0-next".tar.gz'
'kconf-windows-arm64-v2.0.0-next".tar.gz'
'kconf-windows-x86_64-v2.0.0-next".tar.gz'
kconf_darwin_amd64_v1
kconf_darwin_arm64
kconf_linux_386
kconf_linux_amd64_v1
kconf_linux_arm64
kconf_windows_386
kconf_windows_amd64_v1
kconf_windows_arm64
metadata.json$ cat dist/checksums.txt
e5f233e84a8172b87d2558640421d9758db46e1947d79893284553cb0e7f24b6 kconf-darwin-arm64-v2.0.0-next".tar.gz
de35541b69f9ec304acebdbfb6cc4b24d7028a6efa516106d7962c0896b3ca84 kconf-darwin-x86_64-v2.0.0-next".tar.gz
936e0e5326fa11236639433f7d4c9275daa58b08cf857e39666ae0f2a02e0a2c kconf-linux-386-v2.0.0-next".tar.gz
83256d0060b95549c6d1c012c1fc36f202ac0958de4debaa1f46b4970e80c7b0 kconf-linux-arm64-v2.0.0-next".tar.gz
8c60ebdb8caa2457bc9da48b3e2ae0690c45276456f016993cd50b4153dfd468 kconf-linux-x86_64-v2.0.0-next".tar.gz
9cf8a9c7befd728bab24b1b3b68a0efe48622912474efc76e94d5ddc2037fe53 kconf-windows-386-v2.0.0-next".tar.gz
dd864fcb8c01228694d7456778219e0dcb68f9b885a9e97c5d87d0b827e03ad0 kconf-windows-arm64-v2.0.0-next".tar.gz
861a07173b127406700cf83f82ec0425adb4a8b0e5301f15b5dc05d81c078b76 kconf-windows-x86_64-v2.0.0-next".tar.gzAfter$ goreleaser release --snapshot --clean
• starting release...
• loading path=.goreleaser.yml
• skipping announce, publish and validate...
• loading environment variables
• getting and validating git state
• git state commit=b1261a8544ac8e1b806de9dae11dd6b078308ada branch=main current_tag=v2.0.0 previous_tag=v1.12.0 dirty=true
• pipe skipped reason=disabled during snapshot mode
• parsing tag
• setting defaults
• snapshotting
• building snapshot... version=v2.0.0-next
• running before hooks
• running hook=go mod download
• took: 1s
• checking distribution directory
• cleaning dist
• loading go mod information
• took: 1s
• build prerequisites
• writing effective config file
• writing config=dist/config.yaml
• building binaries
• building binary=dist/kconf_windows_386/kconf.exe
• building binary=dist/kconf_windows_arm64/kconf.exe
• building binary=dist/kconf_darwin_arm64/kconf
• building binary=dist/kconf_windows_amd64_v1/kconf.exe
• building binary=dist/kconf_linux_386/kconf
• building binary=dist/kconf_linux_amd64_v1/kconf
• building binary=dist/kconf_linux_arm64/kconf
• building binary=dist/kconf_darwin_amd64_v1/kconf
• took: 5s
• archives
• creating archive=dist/kconf-windows-386-v2.0.0-next.tar.gz
• creating archive=dist/kconf-darwin-x86_64-v2.0.0-next.tar.gz
• creating archive=dist/kconf-darwin-arm64-v2.0.0-next.tar.gz
• creating archive=dist/kconf-linux-386-v2.0.0-next.tar.gz
• creating archive=dist/kconf-linux-arm64-v2.0.0-next.tar.gz
• creating archive=dist/kconf-windows-arm64-v2.0.0-next.tar.gz
• creating archive=dist/kconf-windows-x86_64-v2.0.0-next.tar.gz
• creating archive=dist/kconf-linux-x86_64-v2.0.0-next.tar.gz
• took: 3s
• calculating checksums
• storing release metadata
• writing file=dist/artifacts.json
• writing file=dist/metadata.json
• release succeeded after 9s
• thanks for using goreleaser!$ ls -1 dist
artifacts.json
checksums.txt
config.yaml
kconf-darwin-arm64-v2.0.0-next.tar.gz
kconf-darwin-x86_64-v2.0.0-next.tar.gz
kconf-linux-386-v2.0.0-next.tar.gz
kconf-linux-arm64-v2.0.0-next.tar.gz
kconf-linux-x86_64-v2.0.0-next.tar.gz
kconf-windows-386-v2.0.0-next.tar.gz
kconf-windows-arm64-v2.0.0-next.tar.gz
kconf-windows-x86_64-v2.0.0-next.tar.gz
kconf_darwin_amd64_v1
kconf_darwin_arm64
kconf_linux_386
kconf_linux_amd64_v1
kconf_linux_arm64
kconf_windows_386
kconf_windows_amd64_v1
kconf_windows_arm64
metadata.json$ cat dist/checksums.txt
90613e73a52504d10903f679df8947d925fb364f8a3877b1e51398b9af44652d kconf-darwin-arm64-v2.0.0-next.tar.gz
1c9970887a8a032a1fca720b7815711896979f3d5b2cf26ae80f1f9dc63df3cc kconf-darwin-x86_64-v2.0.0-next.tar.gz
8f7abaa414733287eaccaeedb7bd2700ee33ef71317db8e74a9f6040cdd23c2f kconf-linux-386-v2.0.0-next.tar.gz
ac8ecd6cb7b86de39f76e94c215f5510b6343f9869322e5e781c56ff484de446 kconf-linux-arm64-v2.0.0-next.tar.gz
7ca57df9d1fd8866afdd15da52fa09e2433e04b7e84bd65488ba37388a2de035 kconf-linux-x86_64-v2.0.0-next.tar.gz
07371722a86a52ad0209f54f5c3708740c5cc626d3a9a3dd009e5e6aca569f8c kconf-windows-386-v2.0.0-next.tar.gz
6ef0e392f9554e8e5cc036b3d02c7ac9156f3be20be7d5d67827fe1fbb17162d kconf-windows-arm64-v2.0.0-next.tar.gz
4911f34cad3e5635a274ec521b2d4b28b5582f4908ac04b5e3dbe718f9b72ffb kconf-windows-x86_64-v2.0.0-next.tar.gz |
|
8404617 caused the bug. |
|
Thanks for the catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? (description)
Remove a double quote from the template of asset names.
Why? (reasoning)
This double quote is apparently unnecessary.
GitHub Releases removes double quotes from asset names automatically, but asset names in checksum files still have double quotes so the checksum file was broken.
https://github.com/particledecay/kconf/releases/tag/v2.0.0
https://github.com/particledecay/kconf/releases/download/v2.0.0/checksums.txt
Screenshots (if applicable)
GitHub Issue (if applicable)
Acceptance
Check your PR for the following: