Skip to content

Commit

Permalink
Adds ignore for peg.rs and updates nightly for coverage (#22)
Browse files Browse the repository at this point in the history
The Pest generated parser yields code paths that are hard to target for
coverage.  This is not an excuse to not target good coverage, but we
should do this systematically through broader PartiQL tests and/or fuzz
testing.

This also updates the coverage CI to `nightly-2021-05-09`.
  • Loading branch information
almann committed May 22, 2021
1 parent 9563ec6 commit d748ebd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/codecov.yml
Expand Up @@ -8,3 +8,8 @@ coverage:
default:
target: 85%
threshold: 5%

ignore:
# Ignore the Pest generated code until we have a better way to test
# and target coverage for it
- "partiql-parser/src/peg.rs"
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Expand Up @@ -23,7 +23,7 @@ jobs:
with:
profile: minimal
# nightly can be very volatile--pin this to a version we know works well...
toolchain: nightly-2021-04-24
toolchain: nightly-2021-05-09
override: true
- name: Cargo Test
uses: actions-rs/cargo@v1
Expand Down

0 comments on commit d748ebd

Please sign in to comment.