Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make failure of Octopart import more verbose #1149

Open
christianlupus opened this issue Aug 7, 2020 · 2 comments
Open

Make failure of Octopart import more verbose #1149

christianlupus opened this issue Aug 7, 2020 · 2 comments
Labels
Backend Feature Request Low Priority
Milestone
future

Comments

@christianlupus
Copy link
Collaborator

Feature description

At the moment the GUI does not yield a warning/error message if a lookup at Octopart fails.

A clear error message would be favorable as users do not know that the API call failed and consider a bug in PK.

References

See e.g. #1146.

Alternatives

In the web server's logs (or the PHP logs if separated) a small information is found that the Octopart access was not allowed. The admin can of course look there but there might be much flutter around depending on the traffic of the whole server.
@christianlupus christianlupus added this to the future milestone Aug 7, 2020
@sibbi77
Copy link
Contributor

sibbi77 commented Aug 12, 2020

implemented in PR #1150

@matthijskooijman
Copy link
Contributor

Is this actually fixed by #1150? That one is merged, so maybe this issue could be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Backend Feature Request Low Priority
Projects
None yet
Milestone
future
Development

No branches or pull requests
3 participants
@matthijskooijman @sibbi77 @christianlupus