Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK examples #1

Merged
merged 5 commits into from
May 30, 2023
Merged

SDK examples #1

merged 5 commits into from
May 30, 2023

Conversation

OvidijusSobut
Copy link
Contributor

No description provided.

README.md Outdated

$partnero = new Partnero("api_key");

$partnero->partners()->list(limit: 10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let remove variable names.

README.md Outdated
$partner = (new Partner())
->setEmail('test@mail.com')
->setName("Name")
->setSurname("Surname")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let remove surname too, we will move to use only name in the future

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, maybe lets leave it for partners and don't show for customers only 🤔

$partnero = new Partnero("api_key");

$partner = (new Partner())
->setEmail('john.doe@mail.com')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to be consistent with double or single quotes. I'm voting for single.

README.md Outdated
```

<a name="settings-api"></a>
## Settings
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop settings part to the end, we need to think if we need this one at all.

Copy link
Contributor

@mindaugasmailer mindaugasmailer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think main thing to be consistent through all readme

@OvidijusSobut OvidijusSobut merged commit 73c011b into main May 30, 2023
@OvidijusSobut OvidijusSobut deleted the sdk-examples branch May 30, 2023 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants