Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in generated code #39

Closed
mehmetsalgar opened this issue Feb 7, 2018 · 9 comments
Closed

Comments in generated code #39

mehmetsalgar opened this issue Feb 7, 2018 · 9 comments
Assignees
Labels

Comments

@mehmetsalgar
Copy link

Hi,

colfer place the name of schema file to the comment it generates via Maven Plugin, I am using a Windows machine and colfer does not escape the "" in file path and java compiler then complains about 'illegal escape character', is there a way to disable this comment or let it the colfer escape it before putting in the comment?

Thx

@pascaldekloe pascaldekloe self-assigned this Feb 7, 2018
@pascaldekloe
Copy link
Owner

Understood. Can you share the generated comment line which causes the Java compiler to fail?
You'll have a solution by tomorrow.

@mehmetsalgar
Copy link
Author

sure

@javax.annotation.Generated(value="colf(1)", comments="Colfer from schema file D:\workspace\sample_colfr\org\test\colfer\vo\ProductContainer.java")
public class ProductContainer implements Serializable {

}

@pascaldekloe
Copy link
Owner

Right, you mean those annotations. Yes they must be escaped of course. No problem.

@pascaldekloe
Copy link
Owner

Does this fix work for you @mehmetsalgar? Can you use a snapshot or shall I build a release (including Maven pugin)?

@ginopablo
Copy link

when will this fix be released for maven-plugin? thanks in advance.

@pascaldekloe
Copy link
Owner

pascaldekloe commented Feb 12, 2018

Most likely in a few months from now. If that's too late for you @ginopablo then I will make a release now. Takes about 40 minutes or so.

@ginopablo
Copy link

Thank for your reply. Yes that's too late for me. if i can get a release, i'm keeping colfer in our application.

@pascaldekloe
Copy link
Owner

Done @ginopablo. ✔️ The Maven plugin version 1.11.1 should be in central shortly.

@ginopablo
Copy link

It works of course! Great support, thanks @pascaldekloe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants