Skip to content

Commit

Permalink
Rename Vue.js to Vue
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalgrimaud committed Jul 12, 2020
1 parent a1ca1a9 commit aa923aa
Show file tree
Hide file tree
Showing 21 changed files with 39 additions and 171 deletions.
42 changes: 21 additions & 21 deletions .github/workflows/vuejs.yml → .github/workflows/vue.yml
Expand Up @@ -17,7 +17,7 @@
# limitations under the License.
#

name: Vue.js
name: Vue
on:
push:
branches-ignore:
Expand Down Expand Up @@ -58,63 +58,63 @@ jobs:
node_version: [12.16.1]
os: [ubuntu-latest]
app-type:
- vuejs-default
- vuejs-noi18n
- vuejs-fulli18n-es
- vuejs-gateway
- vuejs-gradle-session
- vuejs-ws-theme
- vuejs-oauth2
- vuejs-couchbase
- vuejs-mongodb-kafka-cucumber
- vuejs-session-cassandra-fr
- vue-default
- vue-noi18n
- vue-fulli18n-es
- vue-gateway
- vue-gradle-session
- vue-ws-theme
- vue-oauth2
- vue-couchbase
- vue-mongodb-kafka-cucumber
- vue-session-cassandra-fr
include:
- app-type: vuejs-default
- app-type: vue-default
entity: sql
profile: prod
war: 0
protractor: 1
- app-type: vuejs-noi18n
- app-type: vue-noi18n
entity: sql
profile: prod
war: 0
protractor: 1
- app-type: vuejs-fulli18n-es
- app-type: vue-fulli18n-es
entity: sql
profile: prod
war: 0
protractor: 1
- app-type: vuejs-gateway
- app-type: vue-gateway
entity: sql
profile: dev,webpack
war: 0
protractor: 1
- app-type: vuejs-gradle-session
- app-type: vue-gradle-session
entity: sql
profile: dev,webpack
war: 0
protractor: 1
- app-type: vuejs-ws-theme
- app-type: vue-ws-theme
entity: sql
profile: dev,webpack
war: 0
protractor: 1
- app-type: vuejs-oauth2
- app-type: vue-oauth2
entity: sql
profile: prod
war: 0
protractor: 1
- app-type: vuejs-couchbase
- app-type: vue-couchbase
entity: couchbase
profile: dev,webpack
war: 0
protractor: 1
- app-type: vuejs-mongodb-kafka-cucumber
- app-type: vue-mongodb-kafka-cucumber
entity: mongodb
profile: dev,webpack
war: 0
protractor: 1
- app-type: vuejs-session-cassandra-fr
- app-type: vue-session-cassandra-fr
entity: cassandra
profile: dev,webpack
war: 0
Expand Down
Expand Up @@ -390,7 +390,7 @@ const vueFiles = {

function writeFiles() {
mkdirp(MAIN_SRC_DIR);
// write Vue.js files
// write Vue files
this.writeFilesToDisk(vueFiles, this, false, this.fetchFromInstalledJHipster('client/templates/vue'));

if (!this.enableTranslation) {
Expand Down
2 changes: 1 addition & 1 deletion generators/client/index.js
Expand Up @@ -23,7 +23,7 @@ const BaseBlueprintGenerator = require('../generator-base-blueprint');
const prompts = require('./prompts');
const writeAngularFiles = require('./files-angular').writeFiles;
const writeReactFiles = require('./files-react').writeFiles;
const writeVueFiles = require('./files-vuejs').writeFiles;
const writeVueFiles = require('./files-vue').writeFiles;
const packagejs = require('../../package.json');
const constants = require('../generator-constants');
const statistics = require('../statistics');
Expand Down
2 changes: 1 addition & 1 deletion generators/page/files.js
Expand Up @@ -86,7 +86,7 @@ function writeFiles() {
this.pageFolderName = this.pageName.toLowerCase();
this.pageInstance = _.lowerFirst(this.pageName);

// write client side files for Vue.js
// write client side files for Vue
this.writeFilesToDisk(vueFiles, this, false, `${CLIENT_VUE_TEMPLATES_DIR}`);

// Add page paths to routing system
Expand Down
2 changes: 1 addition & 1 deletion generators/utils.js
Expand Up @@ -786,7 +786,7 @@ function isGitInstalled(callback) {
}

/**
* Replace translation for Vue.js application
* Replace translation for Vue application
* @param {*} generator
* @param {*} files
*/
Expand Down
6 changes: 3 additions & 3 deletions rfcs/2-jhipster-rfc-jhipster-control-center.md
Expand Up @@ -26,7 +26,7 @@

[summary]: #summary

As of JHipster 6.5, the JHipster administrator's management and monitoring UI is spread out to various places (JHipster Registry, angular/react/vue.js pages) which causes code duplication and slows down their evolution. This RFC proposes to move this functionality to an external application that can be used in different development and production scenarios. In the following, this application will be referred to as the **JHipster Control Center**.
As of JHipster 6.5, the JHipster administrator's management and monitoring UI is spread out to various places (JHipster Registry, angular/react/vue pages) which causes code duplication and slows down their evolution. This RFC proposes to move this functionality to an external application that can be used in different development and production scenarios. In the following, this application will be referred to as the **JHipster Control Center**.

## Motivation

Expand Down Expand Up @@ -89,7 +89,7 @@ Implementation details will be left to the discretion of the **JHipster Control
- A separate **JHipster Control Center** GitHub repository will host the application and allow collaboration.
- The **JHipster Control Center** application will be based on a Java reactive Spring Boot application using Spring Cloud Gateway as embedded proxy technology.
- The application will include Spring Cloud dependencies to allow it to plug into Eureka, Consul and Kubernetes service discovery mechanism.
- The Management UI will be developed using Vue.js and can reuse some the existing code that currently lives in the "Admin pages" of a JHipster application.
- The Management UI will be developed using Vue and can reuse some the existing code that currently lives in the "Admin pages" of a JHipster application.
- The application will be packaged as a docker image and a jar file which will be published on Docker Hub and Maven Central.
- After the initial **JHipster Control Center** 1.0 release, it will be expected to keep backward compatibility with JHipster applications generated with JHipster version 7.0 or higher.
- The **JHipster Control Center** will be an optional part of JHipster so that users will not have to use it. However, we think that it will provide sufficient improvements to the development and operational experience to convince users to adopt it.
Expand All @@ -109,7 +109,7 @@ Compared to today's situation, the proposed solution would have the following ad

- Reduce the generated code as code related to management screens will no longer be generated
- Faster build times for the front end resulting from less front-end code to compile
- Stop developing the same management UI with 3 different frontend framework (Angular, React and Vue.js)
- Stop developing the same management UI with 3 different frontend framework (Angular, React and Vue)
- Improve security as management endpoint will no longer be exposed to the outside but only internally on a separate port. Also the **JHipster Control Center** can have proper authentication (JWT, OAuth) rather than the basic authentication scheme that is present on the JHipster registry (which is the only scheme supported by the Eureka server).

## Prior art
Expand Down
99 changes: 0 additions & 99 deletions test-integration/scripts/10-install-jhipster-vuejs.sh

This file was deleted.

33 changes: 0 additions & 33 deletions test-integration/scripts/12-generate-project-vuejs.sh

This file was deleted.

2 changes: 1 addition & 1 deletion test/page.spec.js
Expand Up @@ -11,7 +11,7 @@ const pageName = 'MyTestPage';
const pageFolderName = 'mytestpage';
const pageInstance = 'myTestPage';

describe('Subgenerator page for Vue.js application', () => {
describe('Subgenerator page for Vue application', () => {
describe('Create page', () => {
before(done => {
helpers
Expand Down
2 changes: 1 addition & 1 deletion test/templates/ngx-blueprint/HelloVue.html.ejs
Expand Up @@ -16,7 +16,7 @@
<html lang="en">
<meta>
<meta charset="UTF-8">
<title>Hello World in Vue.js</title>
<title>Hello World in Vue</title>
</meta>

<body>
Expand Down
18 changes: 9 additions & 9 deletions test/vuejs.spec.js → test/vue.spec.js
Expand Up @@ -216,7 +216,7 @@ const expectedFiles = {
],
};

describe('Vue.js applications', () => {
describe('Vue applications', () => {
describe('Default with Maven', () => {
before(done => {
helpers
Expand Down Expand Up @@ -244,7 +244,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.file(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -297,7 +297,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.file(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -350,7 +350,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.noFile(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -402,7 +402,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.noFile(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -457,7 +457,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.file(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -512,7 +512,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.file(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -566,7 +566,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.file(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down Expand Up @@ -620,7 +620,7 @@ describe('Vue.js applications', () => {
})
.on('end', done);
});
it('creates expected files from jhipster vue.js generator', () => {
it('creates expected files from jhipster Vue generator', () => {
assert.file(expectedFiles.i18n);
assert.file(expectedFiles.common);
assert.file(expectedFiles.app);
Expand Down

0 comments on commit aa923aa

Please sign in to comment.