support for product attributes with terms #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for that contribution! Will put the new version up shortly. |
|
fantastic, let me know so I can update our codebase again pointing to your package. thank you for maintaining this package. |
|
It's updated now!
…-------- Original message --------
From: Majid Hajian <notifications@github.com>
Date: 6/02/20 12:03 (GMT+12:00)
To: pasdo501/gatsby-source-woocommerce <gatsby-source-woocommerce@noreply.github.com>
Cc: Dominik Paschke <dominikpaschke@hotmail.com>, State change <state_change@noreply.github.com>
Subject: Re: [pasdo501/gatsby-source-woocommerce] support for product attributes with terms (#27)
fantastic, let me know so I can update our codebase again pointing to your package.
thank you for maintaining this package.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub<#27?email_source=notifications&email_token=AGWGFMEUOWWDFR5DYVPPGD3RBNAU5A5CNFSM4KOSW5V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK5JZ6A#issuecomment-582655224>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGWGFMGQ5YYZ2BNYCIKLSBTRBNAU5ANCNFSM4KOSW5VQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
One of the issues that I faced today was to get all attributes terms which are not supported at the moment in the plugin.
I have just added it so terms can also appear in the query.
Thanks,
Majid