Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing timestamps with zone 'Z' #17

Merged
merged 2 commits into from
Apr 12, 2021
Merged

Fix parsing timestamps with zone 'Z' #17

merged 2 commits into from
Apr 12, 2021

Conversation

minus7
Copy link

@minus7 minus7 commented Apr 12, 2021

Since timestamps are defined to be ISO 8601, parsing a 'Z' as timezone
offset should be supported. For compatibility, generating of timestamps is untouched, i.e. still generates zone offsets '+00:00'.

Since timestamps are defined to be ISO 8601, parsing a 'Z' as timezone
offset should be supported.
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #17 (25cfcd3) into main (74420ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #17   +/-   ##
=========================================
  Coverage     83.10%   83.10%           
  Complexity      251      251           
=========================================
  Files            54       54           
  Lines           734      734           
  Branches         53       53           
=========================================
  Hits            610      610           
  Misses           94       94           
  Partials         30       30           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74420ed...25cfcd3. Read the comment docs.

@bdemers
Copy link
Contributor

bdemers commented Apr 12, 2021

Thanks @minus7 ! I just pushed a commit: 25cfcd3 to format date strings to use the id as well. IMHO, it's easier to keep things consistent.
Thoughts?

@minus7
Copy link
Author

minus7 commented Apr 12, 2021

I first had it like that as well, but then kept the '+00:00' to avoid breaking people's broken ISO8601 parsers. On the other hand, that's not really a bad thing. LGTM

@bdemers bdemers merged commit 6afdd34 into paseto-toolkit:main Apr 12, 2021
@bdemers
Copy link
Contributor

bdemers commented Apr 12, 2021

Thanks @minus7 !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants