Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in json reporting for cans != 4 #87

Merged
merged 1 commit into from Oct 13, 2018
Merged

Bug fix in json reporting for cans != 4 #87

merged 1 commit into from Oct 13, 2018

Conversation

pnprog
Copy link
Contributor

@pnprog pnprog commented Oct 7, 2018

The json formatting was incorrect for cans values (defined at line 146) different than 4.
I modified the values of cans to extract more data using goreviewpartner and found out about this bug.

The json formatting was incorrect for cans values (defined at line 146) different than 4.
@lemonsqueeze
Copy link
Collaborator

Hi,

I saw your post on lifein19x19, please discuss pull request details here instead, this thread isn't meant for development purposes:

I searched in the code, and modified the values for the number of variations, and deepness for each variations. But the resulting json formatting was incorrect (some comma missing between elements of arrays). I was able to modify the code to fix it, compiled it and tested it on my computer.

Next I sent a pull request on the project's Github, and got a tons of issues with that Travis CI build. I don't know much about C++, but I am fairly confident this is unrelated to the code changes I mage:

The command "if [ "$TRAVIS_OS_NAME" = linux ] && [ "$DCNN" = 1 ]; then sudo apt-get install libcaffe-cpu-dev -y ; fi" failed and exited with 100 during .

I don't know what to do next to have that pull request, accepted. Could you help me check?

Yeah, sometimes apt-get fails for some reason on the travis machine. Usually it's just a matter of triggering the build again, let me see ...

@lemonsqueeze lemonsqueeze merged commit f9922c8 into pasky:master Oct 13, 2018
@pnprog pnprog deleted the patch-2 branch October 14, 2018 09:30
@pnprog
Copy link
Contributor Author

pnprog commented Oct 14, 2018

I saw your post on lifein19x19, please discuss pull request details here instead, this thread isn't meant for development purposes

Sorry about that! It's just that I did not know what to do at the time.

I am looking at the code to see what other data could be "extracted" from Pachi, I maybe have other similar pull requests in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants