Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate draw_samples and draw_sequence #533

Merged
merged 32 commits into from
Jun 19, 2023
Merged

Separate draw_samples and draw_sequence #533

merged 32 commits into from
Jun 19, 2023

Commits on Jun 7, 2023

  1. separate draw_samples and draw_sequence

    @dakk
    dakk committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    0f32556 View commit details
    Browse the repository at this point in the history

  2. rebase

    @dakk
    dakk committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    daafc55 View commit details
    Browse the repository at this point in the history

  3. restore target rendering

    @dakk
    dakk committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    4501e77 View commit details
    Browse the repository at this point in the history

  4. fix linters and types

    @dakk
    dakk committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    91166cf View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. move measurement drawing and draw_interp_pts to draw_sequenece

    @dakk
    dakk committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    2fb542d View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. - add time_slots of type target to ChannelSamples 

    - transform inital_targets to a property
- implements draw_samples and integrate it on draw_sequenece
    @dakk
    dakk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    76276e1 View commit details
    Browse the repository at this point in the history

  2. Fix samples.py typing

    @dakk
    dakk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    9ee018f View commit details
    Browse the repository at this point in the history

  3. remove useless comments

    @dakk
    dakk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    63ab9e4 View commit details
    Browse the repository at this point in the history

  4. - fix _seq_drawer parameters names 

    - fix ChannelSamples field name and order
    @dakk
    dakk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    807c8e8 View commit details
    Browse the repository at this point in the history

  5. fix linting

    @dakk
    dakk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    0bcbf57 View commit details
    Browse the repository at this point in the history

  6. move optional register drawing to draw_samples

    @dakk
    dakk committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ab4f2e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. splitting of drawing of target regions

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    09c580e View commit details
    Browse the repository at this point in the history

  2. fix linters

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    1363f2c View commit details
    Browse the repository at this point in the history

  3. move draw_phase_shifts outside the loop

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    b7b725f View commit details
    Browse the repository at this point in the history

  4. remove duplicate code from draw_sequence

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    3f4afd4 View commit details
    Browse the repository at this point in the history

  5. separate draw_channel_content from draw_samples

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    6757303 View commit details
    Browse the repository at this point in the history

  6. restore _seq_drawer boxes definition position

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    2bd97b6 View commit details
    Browse the repository at this point in the history

  7. minor edits on seq_drawer

    @dakk
    dakk committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    70b3d2c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. adapt draw_phase_area for using sampled_seq in _seq_drawer

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    652484d View commit details
    Browse the repository at this point in the history

  2. - move gather_data to draw_channel_content 

    - minor refactoring
    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    e89d060 View commit details
    Browse the repository at this point in the history

  3. - add _basis_ref to SequenceSamples 

    - move drawing of phase_shifts to _draw_channel_content
    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    0309a42 View commit details
    Browse the repository at this point in the history

  4. - move phase_str into _draw_channel_content

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    3f56a89 View commit details
    Browse the repository at this point in the history

  5. refactoring of _seq_drawer

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    69e9a1f View commit details
    Browse the repository at this point in the history

  6. Refactoring of _seq_drawer.py

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2a7cf7e View commit details
    Browse the repository at this point in the history

  7. fix typo

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    ae3b974 View commit details
    Browse the repository at this point in the history

  8. fix EOM drawing in draw_sequence

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    4706247 View commit details
    Browse the repository at this point in the history

  9. remove useless if

    @dakk
    dakk committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    33b598e View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. - test_draw_samples 

    - rename _TargetSlot to _PulseTargetSlot
- fix duration for draw_samples
- fix eom_buffers creation
- fix draw_phase_area
    @dakk
    dakk committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    38834ab View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2023

  1. - add eom_start_buffers and eom_end_buffers in ChannelSamples 

    - create those buffer in Schedule.get_samples
- Adapt _seq_drawer gather_data for the new buffers
- add a test assert for ChannelSamples.in_eom_mode
    @dakk
    dakk committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    f67d642 View commit details
    Browse the repository at this point in the history

  2. preserve backward compatibility for _TargetSlot

    @dakk
    dakk committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    a0c3692 View commit details
    Browse the repository at this point in the history

  3. Pin numpy version to < 1.25

    @dakk
    dakk committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    6c22203 View commit details
    Browse the repository at this point in the history

  4. use eom_blocks for eom_intervals_ti creation

    @dakk
    dakk committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    b39a25d View commit details
    Browse the repository at this point in the history