New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Allow 0 to be passed as a config to print,write,plot,checkpoint_every and disable in that case #511

Open

awennersteen wants to merge 1 commit into main from aw/disable-print-write-plot-if-0

Member

awennersteen commented Jul 25, 2024

This can be desired behavior in some cases, and is perhaps a better behaviour than the current where we end up raising DivideByZero errors.

We can perhaps use the __post_int__ of the TrainConfig to do more validation here (like negative values), and print a warning?

Not sure what we think is best.


          [FIX] Allow 0 to be passed as a config to print,write,plot,checkpoint…

e526afa

…_every and disable in that case

awennersteen self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment