Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(api) feat: add cache to pcreco #173

Merged
merged 7 commits into from
Jun 28, 2024
Merged

(api) feat: add cache to pcreco #173

merged 7 commits into from
Jun 28, 2024

Conversation

cdelabre
Copy link
Contributor

@cdelabre cdelabre commented Jun 21, 2024

Generic PR

Describe your changes

Add Cache to reduce latency for Vertex AI

Will be tested in 50% ABTest during 7 days. Then, will push it or kill it

Please include a summary of the changes:

This PR [adds/removes/fixes/replaces] the [feature/bug/etc].

Tag a reviewer if necessacy @github/username

Jira ticket number and/or notion link

JIRA-ticket_number

Which API ?

  • API reco
  • API papillon

Type of change

  • New model
  • New endpoint
  • New route
  • Deletion -> what ?:
  • Code Refacto and performance Improvements
  • Testing
  • CI
  • Config

Checklist before requesting a review

  • I have performed a self-review of my code
  • My code passes CI/CD tests
  • I updated README.md
  • My PR contains only a single commit (squash them if needed)
  • I will create a review on slack and ensure to specify the duration of the review task: short (<10min), medium (<30min), long (>30min)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • ⏰ no, but I created a ticket

@cdelabre cdelabre force-pushed the add-cache-to-recommendation branch from 9248056 to 2fbac0e Compare June 24, 2024 09:15
Copy link
Contributor

@lmontier-pass lmontier-pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques questions / suggestions mais sinon c'est fine pour moi :)

@cdelabre cdelabre merged commit 3fdec27 into main Jun 28, 2024
4 checks passed
@cdelabre cdelabre deleted the add-cache-to-recommendation branch June 28, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants