[PC-7746] Stock.dnBookedQuantity for get_active_bookings_quantity_for…

…_venue

  This property isn't usable for this function.
A comment has been added.
Also, fixing the BookingFactory to générate the right amount of
dnBookedQuantity.

src/pcapi/core/bookings/factories.py

@@ -15,13 +15,7 @@ class Meta:
         model = models.Booking
 
     quantity = 1
-    stock = factory.Maybe(
-        "isCancelled",
-        yes_declaration=factory.SubFactory(offers_factories.StockFactory),
-        no_declaration=factory.SubFactory(
-            offers_factories.StockFactory, dnBookedQuantity=factory.SelfAttribute("..quantity")
-        ),
-    )
+    stock = factory.SubFactory(offers_factories.StockFactory)
     token = factory.LazyFunction(random_token)
     user = factory.SubFactory(users_factories.UserFactory)
     amount = factory.SelfAttribute("stock.price")
@@ -45,7 +39,7 @@ def cancellation_date(self, create, extracted, **kwargs):
 
     @classmethod
     def _create(cls, model_class, *args, **kwargs):
-        if kwargs.get("stock") and not kwargs.get("isCancelled", False):
+        if not kwargs.get("isCancelled", False):
             stock = kwargs.get("stock")
             stock.dnBookedQuantity = stock.dnBookedQuantity + kwargs.get("quantity", 1)
             kwargs["stock"] = stock

src/pcapi/core/bookings/repository.py

@@ -190,6 +190,7 @@ def find_expired_bookings_ordered_by_offerer(expired_on: date = None) -> Query:
 
 
 def get_active_bookings_quantity_for_venue(venue_id: int) -> int:
+    # Stock.dnBookedQuantity cannot be used here cause it's only count "not cancelled" bookings.
     return (
         Booking.query.join(Stock)
         .join(Offer)