Skip to content
This repository has been archived by the owner on Nov 22, 2023. It is now read-only.

Commit

Permalink
(PC-8434) make search_group_name non optional
Browse files Browse the repository at this point in the history
  • Loading branch information
antoinewg committed Sep 29, 2021
1 parent 5ae3d1b commit 87958c0
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions src/pcapi/routes/native/v1/serialization/offers.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@
from pydantic.fields import Field

from pcapi.core.bookings.api import compute_cancellation_limit_date
from pcapi.core.categories import categories
from pcapi.core.categories import subcategories
from pcapi.core.categories.categories import CategoryIdEnum
from pcapi.core.categories.subcategories import HomepageLabelNameEnum
from pcapi.core.categories.subcategories import SubcategoryIdEnum
from pcapi.core.offers import repository as offers_repository
from pcapi.core.offers.api import get_expense_domains
from pcapi.core.offers.models import Offer
Expand Down Expand Up @@ -216,7 +214,7 @@ def from_orm(cls: Any, offer: Offer): # type: ignore
isEducational: bool
name: str
category: OfferCategoryResponse
subcategoryId: SubcategoryIdEnum
subcategoryId: subcategories.SubcategoryIdEnum
stocks: list[OfferStockResponse]
image: Optional[OfferImageResponse]
venue: OfferVenueResponse
Expand Down Expand Up @@ -283,11 +281,11 @@ class Config:


class SubcategoryResponseModel(BaseModel):
id: SubcategoryIdEnum
category_id: CategoryIdEnum
id: subcategories.SubcategoryIdEnum
category_id: categories.CategoryIdEnum
app_label: str
search_group_name: Optional[subcategories.SearchGroupNameEnum]
homepage_label_name: HomepageLabelNameEnum
search_group_name: subcategories.SearchGroupNameEnum
homepage_label_name: subcategories.HomepageLabelNameEnum
is_event: bool
online_offline_platform: subcategories.OnlineOfflinePlatformChoicesEnum

Expand All @@ -308,7 +306,7 @@ class Config:


class HomepageLabelResponseModel(BaseModel):
name: HomepageLabelNameEnum
name: subcategories.HomepageLabelNameEnum
value: Optional[str]

class Config:
Expand Down

0 comments on commit 87958c0

Please sign in to comment.