fix: fil arianne #382
Merged
fix: fil arianne #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return index === 1 ? ( | ||
| <React.Fragment key={`${block.__component}_${block.id}`}> | ||
| <Breadcrumb isUnderHeader /> | ||
| <BlockRenderer |
There was a problem hiding this comment.
Est-ce qu'on peut éviter de répéter l'écriture de ce composant ?
There was a problem hiding this comment.
Tu parles de BlockRenderer ? Si oui, si on ne l'affiche pas en index 1, il va nous manquer un bloc ou alors j'ai pas bien compris ta demande.
There was a problem hiding this comment.
Oui, je voyais la factorisation de
const BlockRendererEx = (block)=>(<BlockRenderer
key={`${block.__component}_${block.id}`}
block={block}
/>)
et
index === 1 ? (...<BlockRenderEx block={block} />...) : <BlockRenderEx block={block} />
|
pierrecanthelou
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cette pull request permet d'afficher le fil d'arianne sur toutes les pages.
Celui n'était présent que sur certaine page.
Changements
Les fichiers concernés par les changements :
modified: public_website/src/pages/[...slug].tsx : ajout d'une condition au niveau du render pour afficher Breadcrumb après le header de la page
modified: public_website/src/ui/components/breadcrumb/Breadcrumb.tsx : prise en compte de la deuxième partie de la navigation (aboutItems) et utilisation de isStringAreEquals.
Notion
Plusieurs tickets y font référence.
Exemple : ici