fix: ui #383
Merged
fix: ui #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrecanthelou
approved these changes
Jun 21, 2024
added 13 commits
June 24, 2024 09:04
|
|
||
| return _filtres?.map((filtre) => { | ||
| let uniqueValue: string[] = [] | ||
| switch (filtre.filtre) { |
There was a problem hiding this comment.
Salut, penses-tu pouvoir ne faire qu'une seule fois cette fonction uniqueValue... ?
There was a problem hiding this comment.
Je propose
const toto = {
"Secteur d'activités" : {T:'api::event.event', case:'secteur'},
"Catégories" : {T:'api::event.event', case:'secteur'},
...
}
uniqueValues = uniqueValue(
_data as APIResponseData<toto[filtre.filtre].T>[],
(item) => item.attributes[toto[filtre.filtre].case]
)
| | APIResponseData<'api::news.news'>[] | ||
|
|
||
| export const filterByAttribute = (filtres: Filtre, data: Data) => { | ||
| const _filtres = filtres |
There was a problem hiding this comment.
Ne faut-il pas un deepcopy ici ?
|
pierrecanthelou
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cette pull request ne fait que des mises à jour css, theme... concernant l'UI.
Tickets
Lien 1
Lien 2
Lien 3
Lien 4
Lien 5
Lien 6
Lien 7