Pc 30215 batch event on booking cancel #12914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thconte
force-pushed
the
pc-30215-batch-event-on-booking-cancel
branch
2 times, most recently
from
564716a
to
5edc8a6
Compare
|
|
thconte
force-pushed
the
pc-30215-batch-event-on-booking-cancel
branch
4 times, most recently
from
e1a94d8
to
a6fa21b
Compare
thconte
force-pushed
the
pc-30215-batch-event-on-booking-cancel
branch
from
a6fa21b
to
de8684d
Compare
mageoffray
reviewed
Jun 27, 2024
| @@ -897,7 +898,8 @@ def test_cancel_booking(self, client): | |||
| booking = booking_factories.BookingFactory(user=user) | |||
|
|
|||
| client = client.with_token(self.identifier) | |||
| response = client.post(f"/native/v1/bookings/{booking.id}/cancel") | |||
| with assert_num_queries(29): | |||
There was a problem hiding this comment.
❤️ le commit par contre
There was a problem hiding this comment.
Ouais j'ai pas osé mettre le détail, mais j'ai noté de faire une passe là-dessus en journée back ou autre.
mageoffray
approved these changes
Jun 27, 2024
tanguyprache
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30215
Vérifications