(PC-30523)[API] chore: script to migrate Gibert Joseph to new provider #12923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoudray-pass
force-pushed
the
tcoudray-pass/PC-30523-migration-script-for-Gibert-Joseph
branch
from
0cfe7c3
to
4a23027
Compare
ghost
reviewed
Jun 25, 2024
ghost
reviewed
Jun 25, 2024
ghost
reviewed
Jun 25, 2024
ghost
reviewed
Jun 25, 2024
ghost
reviewed
Jun 25, 2024
tcoudray-pass
force-pushed
the
tcoudray-pass/PC-30523-migration-script-for-Gibert-Joseph
branch
2 times, most recently
from
101e5b1
to
b227e8a
Compare
tcoudray-pass
changed the title
Comment on lines
69
to
70
| if len(venue.venueProviders): | ||
| for venue_provider in venue.venueProviders: |
There was a problem hiding this comment.
(détail)
Suggested change
| if len(venue.venueProviders): | |
| for venue_provider in venue.venueProviders: | |
| for venue_provider in venue.venueProviders: |
Revient au même et est plus direct, non ?
There was a problem hiding this comment.
J'ai repris du code d'un script existant. Je pense que tu as raison mais vu que ce script ne sera mergé, je pense que ce n'est pas grave de le laisser tel quel :)
Comment on lines
+76
to
+108
| edit_venue_provider( | ||
| 2110, # Provider: NUSSEO | ||
| [ # Venues: Gibert Joseph venues | ||
| 18081, | ||
| 17724, | ||
| 17723, | ||
| 17721, | ||
| 17725, | ||
| 17726, | ||
| 17820, | ||
| 17874, | ||
| 17825, | ||
| 17826, | ||
| 17827, | ||
| 17828, | ||
| 17829, | ||
| 14929, | ||
| 17836, | ||
| 17839, | ||
| 17840, | ||
| 17842, | ||
| 17718, | ||
| 17719, | ||
| 17680, | ||
| 17844, | ||
| 17845, | ||
| 49517, | ||
| ], | ||
| "matthieu.geoffray@passculture.app", | ||
| ) |
There was a problem hiding this comment.
Est-ce qu'il ne serait pas préférable de laisser ces paramètres hors de la PR ?
There was a problem hiding this comment.
C'est un script one shot qui ne va pas être mergé et qui va être runné via le job console donc on garde les éléments en dur.
There was a problem hiding this comment.
Et cette adresse email est publique sur git :)
tcoudray-pass
force-pushed
the
tcoudray-pass/PC-30523-migration-script-for-Gibert-Joseph
branch
from
b227e8a
to
5c5115b
Compare
mageoffray
approved these changes
Jun 25, 2024
jeremieb-pass
approved these changes
Jun 25, 2024
tcoudray-pass
force-pushed
the
tcoudray-pass/PC-30523-migration-script-for-Gibert-Joseph
branch
from
5c5115b
to
e7dcd28
Compare
tcoudray-pass
deleted the
tcoudray-pass/PC-30523-migration-script-for-Gibert-Joseph
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30523
Ce script ne sera mergé. Il sera exécuter demain en prod pour permettre au provider NUSSEO de reprendre la main sur les magasins Gilbert Joseph.
Vérifications