(PC-30417)[API] feat: new nav for retention user in sandbox #12924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e7158bb): https://pc-pro-testing--pr12924-pc-30417-sandbox-ret-i0uh8mze.web.app (expires Thu, 04 Jul 2024 08:52:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
Aliochka
force-pushed
the
PC-30417-sandbox-retention-new-nav
branch
6 times, most recently
from
0e89550
to
34c23c9
Compare
scolson-pass
force-pushed
the
PC-30417-sandbox-retention-new-nav
branch
2 times, most recently
from
51fb820
to
1aa6a24
Compare
scolson-pass
force-pushed
the
PC-30417-sandbox-retention-new-nav
branch
2 times, most recently
from
263ccbe
to
aac77ef
Compare
scolson-pass
force-pushed
the
PC-30417-sandbox-retention-new-nav
branch
from
aac77ef
to
7184e91
Compare
(BSR)[PRO] test: fix (BSR)[PRO] test: fix (BSR)[PRO] test: new data again in sandbox comment + linter fix
scolson-pass
force-pushed
the
PC-30417-sandbox-retention-new-nav
branch
from
7184e91
to
cfebde7
Compare
AmineLouveau
reviewed
Jul 2, 2024
AmineLouveau
reviewed
Jul 2, 2024
(BSR)[PRO] test: fix (BSR)[PRO] test: fix
scolson-pass
force-pushed
the
PC-30417-sandbox-retention-new-nav
branch
from
3eadc43
to
e7158bb
Compare
AmineLouveau
approved these changes
Jul 2, 2024
ncanseco-pass
approved these changes
Jul 2, 2024
ogeber
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30417
Commencé par @Aliochka fini par @scolson-pass
Lors de la relecture, ne vous prenez pas trop la tête sur les données utilisées dans la sandbox si ce n'est pas parfait, ça va être remplacé rapidement....
J'ai été obligé de rajouter des contrôles intermédiaires (spinner absent, url chargée, wait, etc...) car simplement cliquer sur un bouton avec un texte et une commande testing-library ne fait pas forcément ce qu'on veut. Une instabilité
venueest également traitée ici.Vérifications