(PC-30329)[API] feat: remove wip_enable_new_nav_ab_test ff and stop ff #12930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AleksDPass
force-pushed
the
AleksDPass/PC-30329-stop-ab-test-remove-ff
branch
from
315eb68
to
b0b2a45
Compare
mageoffray
reviewed
Jun 25, 2024
| ) | ||
| db.session.add(new_nav_pro) | ||
| else: | ||
| new_nav_pro = users_models.UserProNewNavState( |
There was a problem hiding this comment.
On pourrait supprimer la table UserProNewNavState ? Elle n'était utile que si le FF existait non ?
There was a problem hiding this comment.
non puisqu'on veut garder l'ancienne NPP pour les utilisateurs invité. Et la modification ne concerne que les nouveaux utilisateurs. Il faut donc toujours faire la différence avec les actif non actifs. Le passage de tout les utilisateurs en NPP se fera surement avec une PR front. On fera différents tickets pour nettoyer ( routes, tables, fonctions)
yacine-pc
reviewed
Jun 26, 2024
| @@ -0,0 +1,31 @@ | |||
| """remove_FF_WIP_ENABLE_NEW_NAV_AB_TEST | |||
There was a problem hiding this comment.
Suppression de FF faut plutôt faire une migration post
AleksDPass
force-pushed
the
AleksDPass/PC-30329-stop-ab-test-remove-ff
branch
2 times, most recently
from
b738124
to
61e9f7d
Compare
yacine-pc
approved these changes
Jun 26, 2024
xordoquy
approved these changes
Jun 26, 2024
| @@ -0,0 +1,31 @@ | |||
| """remove_FF_WIP_ENABLE_NEW_NAV_AB_TEST | |||
There was a problem hiding this comment.
Suggested change
| """remove_FF_WIP_ENABLE_NEW_NAV_AB_TEST | |
| """remove WIP_ENABLE_NEW_NAV_AB_TEST feature flag |
Comme pour
par ex
AleksDPass
force-pushed
the
AleksDPass/PC-30329-stop-ab-test-remove-ff
branch
2 times, most recently
from
e1673c5
to
37d0035
Compare
no NPP activation by id parity and FF removal. The behavior for invitation remain
AleksDPass
force-pushed
the
AleksDPass/PC-30329-stop-ab-test-remove-ff
branch
from
37d0035
to
440994f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arret de l'AB test et suppression du FF associé.
Maintient de l'ancienne nav pour les utilisateurs invité par ceux qui l'ont.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-30329
Vérifications