(PC-30546)[API] feat: delete future offer when early publish #12935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdasilva-pass
force-pushed
the
qds_PC-30546_future_offer_early_publish
branch
from
6a35c41
to
edef1d7
Compare
prouzet
approved these changes
Jun 26, 2024
|
|
||
| assert response.status_code == 200 | ||
| offer = offers_models.Offer.query.get(stock.offer.id) | ||
| assert offer.publicationDate is None |
There was a problem hiding this comment.
Bonus : tu pourrais vérifier également que :
- l'offre est désormais active ;
- l'offre a bien été indexée :
mock_async_index_offer_ids.assert_called(); - la ligne a bien été supprimée de la table (objet du ticket) :
models.FutureOffer.query.count() == 0.
There was a problem hiding this comment.
Effectivement le test était un peu léger. Merci pour les suggestions, je les ai ajoutées :)
qdasilva-pass
force-pushed
the
qds_PC-30546_future_offer_early_publish
branch
from
edef1d7
to
ecd174b
Compare
ogeber
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira : https://passculture.atlassian.net/browse/PC-30546
Vérifications