Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exit code 1 for cases when script failed to create backup #3

Merged
merged 1 commit into from
May 2, 2024

Conversation

itvexesme
Copy link
Contributor

It allows handle backup.sh script execute issues when running from other scripts.

@CLAassistant
Copy link

CLAassistant commented Mar 31, 2024

CLA assistant check
All committers have signed the CLA.

@dlen
Copy link
Member

dlen commented Apr 4, 2024

Thanks for your contribution @itvexesme! I think it would be more convenient to add a set -e instead of an exit 1
If you are up to modify your PR I'll merge it.

@itvexesme
Copy link
Contributor Author

@dlen As far as I understand set -e logic, it will omit all output by echo about the reason of the issue, that is not quite right.

@dlen
Copy link
Member

dlen commented May 2, 2024

Yeah you are right with the current implementation of the script adding set -e does not make sense unless you want to refactor it into trapping signals.

Thanks!

@dlen dlen merged commit 089b4c5 into passbolt:main May 2, 2024
1 check passed
@itvexesme itvexesme deleted the exit_code_1 branch May 3, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants