Add support for unencrypted description field #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the description field is not encrypted, the resource secrets will contain only a password instead of a JSON containing password and description. Fixes passbolt#9 by detecting if the decrypted resource secrets is a JSON or not and act accordingly. The description field will be extracted from the resource secrets if present, otherwise it will be retrieved from the unencrypted resource details.
|
|
|
Note that I did not test this change against gnupg. I only tested using PGPy. |
|
Many thanks for your PR @RobinR1 👍 I just added this additional commit to handle gnupg GPG library. |
|
I published 0.0.12 with your fix: https://galaxy.ansible.com/ui/repo/published/anatomicjc/passbolt/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the description field is not encrypted, the resource secrets will contain only a password instead of a JSON containing password and description. Fixes #9 by detecting if the decrypted resource secrets is a JSON or not and act accordingly. The description field will be extracted from the resource secrets if present, otherwise it will be retrieved from the unencrypted resource details.