Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Group Update - API/Plugin version 1.6.0 #95

Closed
technogenus opened this issue Jun 22, 2017 · 7 comments
Closed

Error in Group Update - API/Plugin version 1.6.0 #95

technogenus opened this issue Jun 22, 2017 · 7 comments
Assignees
Labels

Comments

@technogenus
Copy link
Contributor

When adding users to an existing group (created when system was at API 1.5 version) we get an interface error of:
error The group could not be saved

Logs show, could not validate GroupUser:

Error: [ValidationException] Could not validate GroupUser
Request URL: /groups/592bda77-d9e0-461f-b2bb-7219c0a8580e.json
Stack Trace:
#0 [internal function]: GroupsController->edit('592bda77-d9e0-4...')
#1 /var/www/passbolt/lib/Cake/Controller/Controller.php(491): ReflectionMethod->invokeArgs(Object(GroupsController), Array)
#2 /var/www/passbolt/lib/Cake/Routing/Dispatcher.php(193): Controller->invokeAction(Object(CakeRequest))
#3 /var/www/passbolt/lib/Cake/Routing/Dispatcher.php(167): Dispatcher->_invoke(Object(GroupsController), Object(CakeRequest))
#4 /var/www/passbolt/app/webroot/index.php(110): Dispatcher->dispatch(Object(CakeRequest), Object(CakeResponse))
#5 {main}

@kevinmuller
Copy link
Member

Hi @technogenus

Thanks for your report.

Can you confirm that when you upgraded to 1.6.0 you followed the update procedure defined in our help section regarding minor updates: http://www.passbolt.com/help/tech/update#toc_minor ?

I am mainly interested to know if you ran the update script:
./app/Console/cake Migrations.migration run all

Thanks!

@technogenus
Copy link
Contributor Author

We followed it exactly and ran both the cake migration for status and two upgrade scripts were reported, then "run all" and both mig scripts appeared to run correctly.

@stripthis
Copy link
Member

@technogenus can you also confirm that you are using the plugin v1.6.0? (just to rule that out)

@technogenus
Copy link
Contributor Author

yes. we are testing PASSBOLT with a regional team of about 20 and we were forced to upgrade the backend quickly today because 90% of the users suddenly had the 1.6.0 plugin... and were mostly locked out of Passbolt with a message "your plugin is not compatible with your API version" message.
We are using a mix of CHROME and FIREFOX. Error occurs in both browsers - but group seems to be updated with the added users, in spite of the error message.

@cedricalfonsi
Copy link
Member

@technogenus

We tried many possible scenarios, but we are still unable to reproduce the bug.
Could you tell me if this bug only impacts a specific category ? or all of them ?

Could you send us a raw dump of the data exchanged between the plugin and the server ? It would help us investigate the issue. To do that, you can follow the instructions below:

  1. Browser: chrome
  2. Open the plugin debug console:
    1.1. Go to chrome://extensions/
    1.2. Locate the passbolt extension
    1.3. In the section Inspect views, click on index.html
  3. Go the network tab
  4. Try to reproduce the issue
  5. Copy the exchanged data:
    4.1. Search for the part that looks like : http://PASSBOLT_DOMAIN/groups/640d1f30-0197-3276-a87e-a1ef389ee5fb.json, it should be the latest one
    4.2. Select it
    4.3. On the headers tab, you should see a Request payload section. Unfold the data, and take a screenshot.
    4.5. On the response tab you copy everything

If you don't want to send sensitive data here, you can obfuscate the data and/or send them to contact@passbolt.com

@technogenus
Copy link
Contributor Author

Thank you for taking the time to look at this. I want to apologize, as this error was related to our customization of notifications. We have implemented custom notification toggle and did not properly update the GroupAdd and GroupDelete notifications added to 1.6.0.

@technogenus
Copy link
Contributor Author

We were able to fix this in our customized Controller-Component-EmailNotificatorComponent.php file and was not a problem with the base 1.6.0 Passbolt. Again, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants