Make keyboard shortcut field case insensitive

[bkazez]

Versions

• Operating system: macOS 13.4 (22F66)
• Browser: 114.0.2 (64-bit)
• PassFF: 1.14.1
• Host app:

Status line output: [18:37:44] show -> (0) no error message

Steps to reproduce the issue

1. Open passff preferences in Firefox
2. Type a new keyboard shortcut with lowercase letters
3. Close passff preferences

Actual behaviour

The shortcut doesn't stick - it reverts back to what it was before

Expected behaviour

The shortcut should stick and the case should be normalized.

[tuxor1337]

Thanks for the report! As an example, try setting it to "ctrl+alt+u" and it will not have any effect. When reloading the preferences page, the field will be reset to its previous value. This can be fixed in

passff/src/modules/preferences.js

Lines 215 to 232 in 2f3fb44

	// Mapping between modifier names in manifest.json and DOM KeyboardEvent.
	let commandModifiers = {
	'Ctrl': browser.runtime.PlatformOs == 'mac' ? 'Meta' : 'Control',
	'MacCtrl': 'Control',
	'Command': 'Meta',
	'Alt': 'Alt',
	'Shift': 'Shift'
	};
	command.shortcut.split(/\s*\+\s*/).forEach((part) => {
	if (commandModifiers.hasOwnProperty(part)) {
	shortcut.expectedModifierState[commandModifiers[part]] = true;
	} else {
	shortcut.commandLetter = part.toLowerCase();
	}
	});
	}
	return shortcut;

by making all the checks case insensitive.

Related: #536

[bkazez]

By the way, how fancy can plugins get on their prefs pages? Without doing a native companion app, could you have custom shortcut selection buttons like this? It would remove the need for documentation and parsing user input.