Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one_member_abstracts should be allowed #2

Closed
passsy opened this issue Sep 23, 2019 · 0 comments
Closed

one_member_abstracts should be allowed #2

passsy opened this issue Sep 23, 2019 · 0 comments

Comments

@passsy
Copy link
Owner

passsy commented Sep 23, 2019 •
edited
Loading

dart-lint/lib/analysis_options.yaml

Lines 348 to 350 in c83db92

# Defining interfaces (abstract classes), with only one method, makes sense architecture wise
# https://dart-lang.github.io/linter/lints/one_member_abstracts.html
- one_member_abstracts

As already definied in the comment, it makes sense to define interfaces (abstract classes in dart) architecture wise when defining boundaries. A Function reference is not a good replacement because it is very likely that new functions will be added which then would result in a breaking change.

Seems like it is accidentally enabled
@passsy passsy closed this as completed in 58007da Oct 4, 2019
passsy added a commit that referenced this issue Oct 4, 2019
@passsy
Disable one_member_abstracts
d818d57 
As already definied in the comment, it makes sense to define interfaces (abstract classes in dart) architecture wise when defining boundaries. A Function reference is not a good replacement because it is very likely that new functions will be added which then would result in a breaking change.

Fixes #2
passsy added a commit that referenced this issue Oct 4, 2019
@passsy
Disable one_member_abstracts
4f948e1 
As already definied in the comment, it makes sense to define interfaces (abstract classes in dart) architecture wise when defining boundaries. A Function reference is not a good replacement because it is very likely that new functions will be added which then would result in a breaking change.

Fixes #2
passsy added a commit that referenced this issue Oct 4, 2019
@passsy
Disable one_member_abstracts
68d683c 
As already definied in the comment, it makes sense to define interfaces (abstract classes in dart) architecture wise when defining boundaries. A Function reference is not a good replacement because it is very likely that new functions will be added which then would result in a breaking change.

Fixes #2
@blendthink blendthink mentioned this issue Mar 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@passsy