Allow blank metadata #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ class SamlMetaData(models.Model): | |||
| blank=True, | |||
| ) | |||
| created_at = models.DateTimeField(auto_now_add=True) | |||
| metadata_contents = models.TextField() | |||
| metadata_contents = models.TextField(blank=True) | |||
There was a problem hiding this comment.
isn't this a validation that only happens on django admin?
There was a problem hiding this comment.
I thought the same but with TextField/CharField it makes it also so that '' is allowed. With other field types it's just django admin validation
| @@ -172,6 +172,10 @@ def acs(r, metadata_id): | |||
| logger.warning("Denied because missing metadata") | |||
| return HttpResponseRedirect(get_reverse([denied, 'denied', 'django_saml2_auth:denied'])) | |||
|
|
|||
| if metadata.metadata_contents == '': | |||
There was a problem hiding this comment.
are we allowing or denying?
There was a problem hiding this comment.
lol it is misleading, what I meant is we want to allow blank metadata at the database level and then don't throw 500 errors
ricardo-passthrough
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From this: https://app.asana.com/0/1205521539367651/1205389957689159
Basically Alex needs to create the SAMLMetaData config in order to get the ACS url to send to the client, but Alex doesn't have the metadata yet. If someone accesses this URL it will throw a 500 (https://console.cloud.google.com/errors/detail/CLXpuafIpquoDg;time=P30D?project=passthrough-prod&utm_source=error-reporting-notification&utm_medium=email&utm_content=resolved-error&pli=1&rapt=AEjHL4MQ-boCDg-X4YpXJeZkR-siEVwhKxTIIS_5mvKlciITJmwjQiVA2eCzzlyLyvO8JBLc9CyHmYrJCuD9zU-3EuICVihkCQ)
Allowing a blank metadata at the DB level and then denying it when someone accesses the URL will prevent this 500 and fail gracefully. No one should use the link anyway until there's a metadata