-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new NPM script to build using tsc to generate types and update package.json to indicate path to types #6
Conversation
I think this would break the demo which imports the minified js directly using a relative path. I think I would have to fix the CDN / README / example links in a few places too, also on the main site and a few other places. It would probably be easier to just add the types directly in That said, I was pondering about making a bigger refactoring. It's described in #7, which would need further compiling adjustments, so I'd rather make it in one swoop with it. Nevertheless, the indications provided are very useful, thank you very much for the assistance. |
Hmm, it was intended to be non-breaking but maybe I missed something. Notice the changed files,
Yes, I remember you mentioned that on a previous issue which is why I didn't mean to change it. I think using
I didn't understand what you meant here. The picture I showed above, the types are in the
Ok, yea. I was mostly sending this to give ideas. If you decide to close the PR and not merge it since you are doing the larger refactor that is ok with me. |
Thanks for the MR ...since the build process is a bit tricky, I ended up repeating your steps one by one as separate commits. Basically, it's now "merged" with slight differences along the way. Thanks. |
I'm not sure if this would be useful but I was playing around with have two build outputs. Using typescript to generate types build while keeping the existing esbuild since it does minification and makes this non-breaking.
I'm not very familiar with the new package.exports config but I think this might help work towards resolving #3