Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fully qualified origin, add unit tests #217

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Conversation

aseigler
Copy link
Collaborator

No description provided.

@aseigler aseigler added the bug Something isn't working label Apr 20, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains a valid label.

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #217 (bd81fd2) into master (83b8214) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   70.82%   70.88%   +0.06%     
==========================================
  Files          69       69              
  Lines        3085     3088       +3     
==========================================
+ Hits         2185     2189       +4     
+ Misses        900      899       -1     
Impacted Files Coverage Δ
Src/Fido2/AuthenticatorResponse.cs 82.97% <100.00%> (+3.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83b8214...bd81fd2. Read the comment docs.

@aseigler aseigler merged commit bdad59e into master Apr 20, 2021
@aseigler aseigler deleted the fully-qualified-origin branch April 20, 2021 21:31
@abergs abergs mentioned this pull request Apr 21, 2021
@aseigler aseigler restored the fully-qualified-origin branch April 21, 2021 15:36
@aseigler aseigler deleted the fully-qualified-origin branch October 18, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant