Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the csproj file so that it can be deployed correctly to an Azure app service #383

Closed
wants to merge 4 commits into from

Conversation

jameswestgate
Copy link

@jameswestgate jameswestgate commented Mar 7, 2023

When trying to deploy the demo to an Azure app service, you encounter the following issue:

dotnet/sdk#251
https://stackoverflow.com/questions/43320772/the-publish-target-is-not-supported-without-specifying-a-target-framework

The csproj file needs to be edited so that the instead of you use . Since only .net 6.0 is targeted, this isn't a problem.

@jameswestgate jameswestgate changed the title Modify the csproj file so that it can be deployed correctly to an Azuze app service Modify the csproj file so that it can be deployed correctly to an Azure app service Mar 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #383 (2e9464f) into master (5e72564) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files          89       89           
  Lines        2531     2531           
  Branches      427      427           
=======================================
  Hits         1944     1944           
  Misses        466      466           
  Partials      121      121           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Regenhardt
Copy link
Contributor

There's way more in this PR than just the csproj change though, how about the whole new project and lots of config files, I think those weren't supposed to be included?

@Regenhardt
Copy link
Contributor

I have temporarily deployed a demo app using these packages without having to modify their project files, it seems to work fine for me:

https://fido2-blazordemo.azurewebsites.net

@jameswestgate
Copy link
Author

Extra commits have been added to the pull request. Apologies. Im also guessing that perhaps this issue is being resolved by an update to VS. The only relevant commit is 66566c8

I suggest we close this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants